Skip to content

Fix target fallback expression parsing in compiled workflows#610

Merged
strawgate merged 1 commit intomainfrom
fix/conflicted-pr-detection
Mar 9, 2026
Merged

Fix target fallback expression parsing in compiled workflows#610
strawgate merged 1 commit intomainfrom
fix/conflicted-pr-detection

Conversation

@strawgate
Copy link
Collaborator

@strawgate strawgate commented Mar 9, 2026

Summary

  • update safe-output fragment configs to use GitHub-expression-safe fallback syntax: target: "$\{\{ inputs.target-pr-number || 'triggering' }}"
  • regenerate compiled lockfiles that embed those safe-output configs so handler JSON and tool descriptions carry the same safe fallback expression
  • fix parsing failures in reusable-workflow callers that evaluate compiled JSON-embedded expressions

Test plan

  • run ./scripts/dogfood.sh
  • run .bin/gh-aw compile --action-mode release --action-tag v0.56.0
  • run ./scripts/backwards-compat.sh
  • verify regenerated lockfiles use $\{\{ inputs.target-pr-number || 'triggering' }} at the previously failing locations

The body of this PR is automatically managed by the Trigger Update PR Body workflow.

Use single-quoted string literals inside target fallback expressions and regenerate lockfiles so GitHub Actions parser accepts the compiled JSON-embedded expressions.

Made-with: Cursor
@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 67cfae5c-8c6b-4e2f-ad0d-830e460fe838

📥 Commits

Reviewing files that changed from the base of the PR and between 052c229 and 046c5b9.

📒 Files selected for processing (18)
  • .github/workflows/gh-aw-dependency-review.lock.yml
  • .github/workflows/gh-aw-estc-docs-pr-review.lock.yml
  • .github/workflows/gh-aw-estc-pr-buildkite-detective.lock.yml
  • .github/workflows/gh-aw-fragments/safe-output-add-comment-pr-hide-older.md
  • .github/workflows/gh-aw-fragments/safe-output-add-comment-pr.md
  • .github/workflows/gh-aw-fragments/safe-output-push-to-pr.md
  • .github/workflows/gh-aw-fragments/safe-output-reply-to-review-comment.md
  • .github/workflows/gh-aw-fragments/safe-output-resolve-thread.md
  • .github/workflows/gh-aw-fragments/safe-output-review-comment.md
  • .github/workflows/gh-aw-fragments/safe-output-submit-review.md
  • .github/workflows/gh-aw-mention-in-pr-by-id.lock.yml
  • .github/workflows/gh-aw-mention-in-pr-no-sandbox.lock.yml
  • .github/workflows/gh-aw-mention-in-pr.lock.yml
  • .github/workflows/gh-aw-pr-actions-detective.lock.yml
  • .github/workflows/gh-aw-pr-actions-fixer.lock.yml
  • .github/workflows/gh-aw-pr-ci-detective.lock.yml
  • .github/workflows/gh-aw-pr-review-addresser.lock.yml
  • .github/workflows/gh-aw-pr-review.lock.yml

📝 Walkthrough

Walkthrough

This PR updates GitHub Actions workflow configuration files across the repository, primarily affecting target PR number handling in safe-outputs handlers. The changes normalize quote styles in JSON string literals—replacing escaped double-quotes with single quotes for the "triggering" fallback value—across multiple workflow lock files and fragment files. Metadata frontmatter hashes are updated to reflect these changes. An artifact upload step for safe-output-items is introduced in one workflow file. No changes to control flow logic or public API signatures are present.

Possibly related PRs

  • #246: Modifies the same gh-aw-pr-buildkite-detective.lock.yml file with matching quote style and safe-outputs configuration changes
  • #429: Directly edits gh-aw-dependency-review.lock.yml with identical quote normalization and artifact upload patterns
  • #378: Updates gh-aw-pr-review-addresser.lock.yml with corresponding GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG quote style adjustments

Suggested labels

medium_boom

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/conflicted-pr-detection
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the medium_boom Medium PR blast radius; likely benefits from human review label Mar 9, 2026
@strawgate strawgate merged commit 14c6d71 into main Mar 9, 2026
23 checks passed
@strawgate strawgate deleted the fix/conflicted-pr-detection branch March 9, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium_boom Medium PR blast radius; likely benefits from human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant