Add "assign to Copilot" as an implementation option in chaining docs#659
Add "assign to Copilot" as an implementation option in chaining docs#659
Conversation
Document the pattern where a detector creates an issue and the follow-up job assigns it to GitHub's Copilot coding agent instead of chaining to a dedicated fixer workflow. Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds documentation for a new workflow pattern "Detector creates issue → assign to Copilot" by introducing an Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Each section (Core, Repository Maintenance, Codebase Maintenance) now has a collapsed "Install" tip with a copy-pasteable curl command that downloads all the example workflows for that category. Made-with: Cursor
Replace the quick-setup.sh script reference with direct curl commands that install the four core workflows. The Get Started section is now self-contained — create PAT, store secret, curl the workflows, push. Made-with: Cursor
The overview page referenced "the quick setup script" without a link. Now links to both the script source and the homepage install commands. Made-with: Cursor
- Explain what Copilot PAT is for before asking the user to create one - Add pr-actions-detective to core set (matches quick-setup script) - Move it out of Repository Maintenance to avoid duplication - Add step 3 with concrete bullet points showing what the agents do - Tighten tagline to explain what the project is, not just count agents - Link to full setup docs for customization - Use consistent "cd into your repo" wording across all install blocks Made-with: Cursor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/index.md (1)
25-34:⚠️ Potential issue | 🔴 Criticalcurl -sL writes error pages into workflow files on HTTP failures.
Lines 25-34, 78-83, and 106-115 use
curl -sL, which exits successfully even on 404/500 responses, writing error HTML into.github/workflows/*.yml. Users end up with broken workflows.Replace all with
curl -fsSLto fail fast on HTTP errors.🔧 Fix for all curl commands
-curl -sL https://raw.githubusercontent.com/elastic/ai-github-actions/v0/gh-agent-workflows/issue-triage/example.yml \ +curl -fsSL https://raw.githubusercontent.com/elastic/ai-github-actions/v0/gh-agent-workflows/issue-triage/example.yml \Apply the same
-sL→-fsSLchange to all remaining curl commands in lines 27-34, 78-83, and 106-115.Also applies to: 78-83, 106-115
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/index.md` around lines 25 - 34, Replace the curl flags that allow silent success on HTTP errors: change every occurrence of "curl -sL" to "curl -fsSL" in the shown commands so curl fails on 4xx/5xx and does not write error HTML into workflow files (update the curl invocations that produce .github/workflows/trigger-issue-triage.yml, trigger-mention-in-issue.yml, trigger-mention-in-pr.yml, trigger-pr-review.yml, trigger-pr-actions-detective.yml and the other curl lines referenced in the comment).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/index.md`:
- Around line 25-34: Replace the curl flags that allow silent success on HTTP
errors: change every occurrence of "curl -sL" to "curl -fsSL" in the shown
commands so curl fails on 4xx/5xx and does not write error HTML into workflow
files (update the curl invocations that produce
.github/workflows/trigger-issue-triage.yml, trigger-mention-in-issue.yml,
trigger-mention-in-pr.yml, trigger-pr-review.yml,
trigger-pr-actions-detective.yml and the other curl lines referenced in the
comment).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7c9c0fa1-cfc9-4f9a-ac7a-003a28844b08
📒 Files selected for processing (2)
docs/index.mddocs/workflows/gh-agent-workflows.md
Fail fast on HTTP errors instead of silently writing error pages into workflow files. Made-with: Cursor
Replace raw API call with the simpler gh CLI command that the cli/cli#11279 PR added for assigning issues to Copilot. Made-with: Cursor
Resolve conflicts with #659 (assign-to-Copilot chaining option). Keep our fixer-removal changes; incorporate the new "assign to Copilot" section and Copilot row in the chaining comparison table. Made-with: Cursor
Summary
docs/workflows/detector-fixer-chaining.md, including a workflow example that assigns detector-created issues withgh issue edit --add-assignee@copilot``.issues: write;COPILOT_GITHUB_TOKENremains in the detector job in the example.docs/index.mdonboarding with explicit core-workflow install commands, refreshed workflow grouping, and collapsible install tips for maintenance workflow sets.curl -fsSL(replacingcurl -sL), plus wording updates indocs/workflows/gh-agent-workflows.md.pymdownx.detailsandpymdownx.superfencesinmkdocs.yml.Test plan
??? tipblocks)The body of this PR is automatically managed by the Trigger Update PR Body workflow.