Added Instrumentation for ServletContainerInitializer#onStartup#2449
Conversation
|
👋 @tobiasstadler Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
|
@felixbarny asking for your review as there seem to be quite a lot of prior context leading to this |
|
@felixbarny It might makes sense to include this in 1.29.0 release, toghter with the other service name/version auto detection. |
…ontainerinitializer-onstartup
...rvlet-plugin/src/main/java/co/elastic/apm/agent/servlet/InitServiceNameInstrumentation2.java
Show resolved
Hide resolved
...rvlet-plugin/src/main/java/co/elastic/apm/agent/servlet/InitServiceNameInstrumentation2.java
Outdated
Show resolved
Hide resolved
| * Determines the service name based on the webapp's {@code META-INF/MANIFEST.MF} file early in the startup process. | ||
| * As this doesn't work with runtime attachment, the service name is also determined when the first request comes in. | ||
| */ | ||
| public abstract class InitServiceNameInstrumentation2 extends AbstractServletInstrumentation { |
There was a problem hiding this comment.
Maybe you could find a better name for this. Don't hesitate to renaming InitServiceNameInstrumentation or creating a dedicated package for both.
There was a problem hiding this comment.
Done, I hope it is ok now.
...rvlet-plugin/src/main/java/co/elastic/apm/agent/servlet/InitServiceNameInstrumentation2.java
Show resolved
Hide resolved
felixbarny
left a comment
There was a problem hiding this comment.
Sorry for all the nitpicks.
...gin/src/main/java/co/elastic/apm/agent/servlet/service_name/Servlet2PlusInstrumentation.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/co/elastic/apm/agent/servlet/service_name/Servlet2PlusInstrumentation.java
Outdated
Show resolved
Hide resolved
...gin/src/main/java/co/elastic/apm/agent/servlet/service_name/Servlet3PlusInstrumentation.java
Outdated
Show resolved
Hide resolved
|
/run elasticsearch-ci/docs |
|
Thank You! |
What does this PR do?
Improves service name and version auto detection
Checklist