JAX-WS @WebMethod is optional#2667
Merged
felixbarny merged 5 commits intoelastic:mainfrom Jun 13, 2022
Merged
Conversation
SylvainJuge
approved these changes
Jun 13, 2022
Comment on lines
+81
to
+83
| && !new TypeList.Explicit(new ArrayList<>(hierarchy)) | ||
| .filter(hierarchyMatcher) | ||
| .isEmpty() |
Member
There was a problem hiding this comment.
[minor] this one probably deserves to be explained a bit, maybe through a comment. If I understand it correctly it's "the type matches the hierarchyMatcher", maybe nesting an IF in this case could help.
| package co.elastic.apm.soap; | ||
|
|
||
| public interface BaseHelloWorldService { | ||
| String sayHello(); |
Member
There was a problem hiding this comment.
[minor] maybe add a small comment to remind that the @WebMethod annotation is optional on the method level.
CHANGELOG.asciidoc
Outdated
| ===== Bug fixes | ||
| * Fix missing attributes in bridged OTel transactions - {pull}2657[#2657] | ||
| * Fix `transaction.result` with bridged OTel transactions - {pull}2660[#2660] | ||
| * Fix for JAX-WS (SOAP) transaction names. Now the agent also properly names transaction for web service methods that are not annotated with `@WebMethod`. - {pull}2667[#2667] |
Member
There was a problem hiding this comment.
The changelog have to be re-updated as it won't be part of today's release.
|
/test |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist