Fix JMX invalid composite value type log message#3849
Merged
JonasKunz merged 3 commits intoelastic:mainfrom Oct 25, 2024
Merged
Fix JMX invalid composite value type log message#3849JonasKunz merged 3 commits intoelastic:mainfrom
JonasKunz merged 3 commits intoelastic:mainfrom
Conversation
SylvainJuge
previously approved these changes
Oct 24, 2024
SylvainJuge
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For JMX metrics we support composite values: Each entry becomes a separate metric.
However, this only works as long as the values of the entries in the composite are numbers. Otherwise we'll print a warning.
This warning was a bit misleading, because it would print the entire composite instead of just the offending value, which gets fixed by this PR.
Checklist
I have added tests that would fail without this fix