Skip to content

chore(deps-dev): bump undici from 6.2.1 to 6.3.0 #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trentm merged 3 commits into from
Jan 16, 2024
Merged

chore(deps-dev): bump undici from 6.2.1 to 6.3.0 #3827

trentm merged 3 commits into from
Jan 16, 2024

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2024 •
edited
Loading

Bumps undici from 6.2.1 to 6.3.0.

Release notes

Sourced from undici's releases.

v6.3.0

What's Changed

New Contributors

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 15, 2024
@dependabot dependabot bot requested a review from a team January 15, 2024 01:21
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 15, 2024
@dependabot
chore(deps-dev): bump undici from 6.2.1 to 6.3.0
e5fdbd3 
Bumps [undici](https://github.com/nodejs/undici) from 6.2.1 to 6.3.0.
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.2.1...v6.3.0)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/undici-6.3.0 branch from d8d21cd to e5fdbd3 Compare January 15, 2024 09:16
@trentm trentm self-assigned this Jan 15, 2024
@trentm
Copy link
Member

trentm commented Jan 15, 2024

test-vers (21) is now breaking because of a change in Node.js v21.6.0 -- which was released in the last day.

% node --version
v21.6.0

% node  test/stacktraces/stacktraces.test.js
...
# Error.prepareStackTrace is set
ok 44 should be truthy
ok 45 Error.prepareStackTrace is set
# Error.prepareStackTrace is not set
ok 46 should be truthy
not ok 47 Error.prepareStackTrace is not set
  ---
    operator: equal
    expected: 'undefined'
    actual:   'ErrorPrepareStackTrace'
    at: done (/Users/trentm/el/apm-agent-nodejs7/test/stacktraces/stacktraces.test.js:497:13)
    stack: |-
      Error: Error.prepareStackTrace is not set
          at Test.assert [as _assert] (/Users/trentm/el/apm-agent-nodejs7/node_modules/tape/lib/test.js:479:48)
          at Test.strictEqual (/Users/trentm/el/apm-agent-nodejs7/node_modules/tape/lib/test.js:661:7)
          at done (/Users/trentm/el/apm-agent-nodejs7/test/stacktraces/stacktraces.test.js:497:13)
          at ChildProcess.exithandler (node:child_process:414:7)
          at ChildProcess.emit (node:events:519:28)
          at maybeClose (node:internal/child_process:1105:16)
          at Socket.<anonymous> (node:internal/child_process:457:11)
          at Socket.emit (node:events:519:28)
          at Pipe.<anonymous> (node:net:337:12)
  ...

1..47
# tests 47
# pass  46
# fail  1

https://nodejs.org/en/blog/release/v21.6.0 mentions the relevant change: nodejs/node#50827

I've opened #3833 to eventually support using this new Node.js feature to allow user's using node --enable-source-maps with our agent. However, for now, we just want to fix the test.

@trentm
correct the 'Error.prepareStackTrace is not set' test assumptions, no…
b8daf03 
…de v21.6.0 sets a default Error.prepareStackTrace
david-luna
david-luna reviewed Jan 16, 2024
View reviewed changes
test/instrumentation/modules/undici/undici.test.js
'error.exception.message',
);
// https://developer.mozilla.org/en-US/docs/Web/API/DOMException#aborterror
t.equal(error.exception.code, '20', 'error.exception.code');
Copy link
Member

@david-luna david-luna Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the lib instrumented changes the error codes and messages I guess it's expected and anyone having a query on ElasticSearch/Kibana should update it accordingly. But shouldn't error.exception.module be defined here with the value undici?

Copy link
Member

@trentm trentm Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC error.exception.module comes from reading the err.stack. Now that Undici is passing through the Error object set on the abort.reason instead of creating its own, the err.stack points to a location in Node.js core where it is created (this loc: https://github.com/nodejs/node/blob/e133e5115a829aa7a445cfd8754df3a3dd586b0a/lib/internal/abort_controller.js#L395). That means the top frame in err.stack no longer points to a location in the undici module.

@trentm trentm requested a review from david-luna January 16, 2024 17:57
@trentm trentm merged commit 6c6d90a into main Jan 16, 2024
@trentm trentm deleted the dependabot/npm_and_yarn/undici-6.3.0 branch January 16, 2024 18:14
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
@dependabot @trentm @PeterEinberger
chore(deps-dev): bump undici from 6.2.1 to 6.3.0 (elastic#3827)
124118b 
* fix test assertions for AbortController changes in undici@6.3.0
* correct the 'Error.prepareStackTrace is not set' test assumptions, node v21.6.0 sets a default Error.prepareStackTrace

Co-authored-by: Trent Mick <trent.mick@elastic.co>
@trentm trentm restored the dependabot/npm_and_yarn/undici-6.3.0 branch November 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trentm trentm trentm left review comments

@david-luna david-luna david-luna approved these changes

Assignees

@trentm trentm

Labels

agent-nodejs Make available for APM Agents project planning. dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

APM-Agents (OLD)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trentm @david-luna