Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
* Add disable_metrics_thread conf * Only use the transport background thread * Singleton client for the whole lambda file * Flush after transaction
This reverts commit 84ead98.
beniwohli
left a comment
There was a problem hiding this comment.
Regarding time_to_perf_counter, it generally LGTM. I worry however that especially in an environment like Lambda, where the runtime is put to sleep and woken up on a regular basis, clock skew could be a phenomenon that is more regular than usual. But that's just a hunch...
I don't think that's actually an issue in this case. Edit: I am going to do some testing around |
|
Did some testing today and the conversion measurement we take at the beginning of the cold start appears to stay accurate throughout multiple invocations, with freezes in between. I'm still going to implement some re-measurement for long-running processes but I don't think we need to measure every time with Lambda like I was fearing. |
beniwohli
left a comment
There was a problem hiding this comment.
Great work, looks good!
I think we need a better solution for passing state along in the capture_serverless object. Especially when used as a module-level decorator, the chance of things going awry are pretty big IMO.
Remaining:
Related issues
Ref #428