refactor: replace github.com/olekukonko/tablewriter with text/tablewriter#40158
Conversation
…iter the downside is that there's no separator between headers and table content but that's a style issue.
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
efd6
left a comment
There was a problem hiding this comment.
It would be nice to gate this output behind a verbose flag; at the moment go test emits all this, but this behaviour is not conventional for go testing. If this is done, it could be in another PR.
I've updated the test to use the test writer so it should be consistent with test flags and log behaviour (e.g. log during failure or verbose flag) EDIT: go 1.25 only :( |
Proposed commit message
replace github.com/olekukonko/tablewriter with text/tablewriter
the downside is that there's no separator between headers and table content but that's a style issue.
Header content has been uppercased to keep the same behaviour (tablewriter was uppercasing them under the hood).
columns are separated by
|just like before but there's no+------+-----------------------+--------+at the beginning and the end of the table.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs