Skip to content

refactor: replace github.com/olekukonko/tablewriter with text/tablewriter#40158

Merged
kruskall merged 8 commits into
elastic:mainfrom
kruskall:refactor/tablewriter
Sep 14, 2025
Merged

refactor: replace github.com/olekukonko/tablewriter with text/tablewriter#40158
kruskall merged 8 commits into
elastic:mainfrom
kruskall:refactor/tablewriter

Conversation

@kruskall
Copy link
Copy Markdown
Member

@kruskall kruskall commented Jul 9, 2024

Proposed commit message

replace github.com/olekukonko/tablewriter with text/tablewriter

the downside is that there's no separator between headers and table content but that's a style issue.
Header content has been uppercased to keep the same behaviour (tablewriter was uppercasing them under the hood).

columns are separated by | just like before but there's no +------+-----------------------+--------+ at the beginning and the end of the table.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

…iter

the downside is that there's no separator between headers and table content
but that's a style issue.
@kruskall kruskall requested review from a team as code owners July 9, 2024 21:10
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 9, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jul 10, 2024
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 26, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify Bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 26, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 26, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b refactor/tablewriter upstream/refactor/tablewriter
git merge upstream/main
git push upstream refactor/tablewriter

@zmoog zmoog added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label May 29, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@zmoog zmoog removed the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 29, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 29, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b refactor/tablewriter upstream/refactor/tablewriter
git merge upstream/main
git push upstream refactor/tablewriter

Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to gate this output behind a verbose flag; at the moment go test emits all this, but this behaviour is not conventional for go testing. If this is done, it could be in another PR.

@kruskall kruskall requested a review from a team as a code owner September 14, 2025 13:14
@kruskall
Copy link
Copy Markdown
Member Author

kruskall commented Sep 14, 2025

It would be nice to gate this output behind a verbose flag; at the moment go test emits all this, but this behaviour is not conventional for go testing. If this is done, it could be in another PR.

I've updated the test to use the test writer so it should be consistent with test flags and log behaviour (e.g. log during failure or verbose flag)

EDIT: go 1.25 only :(

@kruskall kruskall enabled auto-merge (squash) September 14, 2025 13:19
@kruskall kruskall merged commit 577fc84 into elastic:main Sep 14, 2025
207 checks passed
@kruskall kruskall deleted the refactor/tablewriter branch September 14, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants