Skip to content

Let docs-builder know it's running on CI to set landing-page-path#54

Merged
cotti merged 2 commits intomainfrom
fix/docs-link
Apr 1, 2026
Merged

Let docs-builder know it's running on CI to set landing-page-path#54
cotti merged 2 commits intomainfrom
fix/docs-link

Conversation

@cotti
Copy link
Copy Markdown
Contributor

@cotti cotti commented Apr 1, 2026

Without docs-builder knowing it's running on CI, it doesn't set the landing-page-path, which breaks preview docs links.

@cotti cotti requested a review from a team April 1, 2026 17:52
@cotti cotti self-assigned this Apr 1, 2026
@cotti cotti requested a review from Mpdreamz April 1, 2026 17:52
@cotti cotti added the fix label Apr 1, 2026
Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can we also set CI?

@cotti cotti merged commit 37192f7 into main Apr 1, 2026
3 checks passed
@cotti cotti deleted the fix/docs-link branch April 1, 2026 18:06
cotti added a commit that referenced this pull request Apr 7, 2026
* Let docs-builder know it's running on CI to set landing-page-path

* Set CI again.
cotti added a commit that referenced this pull request Apr 22, 2026
* Describe skip label availability and add skip-specific comment

* Let docs-builder know it's running on CI to set landing-page-path (#54)

* Let docs-builder know it's running on CI to set landing-page-path

* Set CI again.

* Add agentic workflow infrastructure and docs-check workflow (#56)

* Add agentic workflow infrastructure and docs-check workflow

Introduces gh-aw agentic workflow support alongside the existing composite
actions. Workflow .md sources live in workflows/ as a library; a compile
script copies them into .github/workflows/ for the gh-aw compiler and
produces .lock.yml files that consumer repos reference via workflow_call.

First workflow: docs-check — analyzes PRs/commits for documentation impact
using the Elastic Docs MCP server and posts structured findings as comments.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Simplify tooling: use gh extension instead of Go binary

Replace go install with gh extension install for the gh-aw compiler.
Drop actionlint binary download — the repo already has it via pre-commit.
Remove bin/ dependency entirely.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix CI failures and address review feedback

- Move `roles` under `on:` (latest gh-aw schema change)
- Exclude .lock.yml from pre-commit trailing-whitespace and end-of-file-fixer
- Replace custom lint/release Makefile targets with `pre-commit run --all`
- Remove release target (release-drafter handles releases)
- Recompile lock file with latest gh-aw

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix CI: recompile with latest gh-aw, exclude lock files from actionlint

- Update gh-aw extension (v0.63.0 → v0.65.5) and recompile lock file
- Exclude .lock.yml from actionlint pre-commit hook (generated files
  reference secrets injected by the gh-aw runtime)
- Fix .gitattributes missing trailing newline

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Rename workflows/ to agentic-workflows/

Update all references in compile script, Makefile, CI, README,
DEVELOPING.md, and workflow docs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add /create-agentic-workflow Claude skill

Interactive skill that scaffolds the three required files for a new
gh-aw agentic workflow: source .md, example.yml trigger, and README.
Guides users through pattern selection, trigger config, and prompt
structure.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Teach skill about fragment selection and creation

Add Step 3 that reads available fragments, explains what each provides
and when to include it, documents import rules, and guides users on
when to create new fragments vs. reuse existing ones.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Harden release workflows against tag injection and credential leakage (#45)

* Harden release workflows against tag injection and credential leakage

Made-with: Cursor

* Set workflow-level permissions to {} for least-privilege

The job already declares contents: write, so the workflow-level
contents: read was redundant. Empty permissions at workflow level
ensures no implicit grants.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Remove post-skipped-comment

* Update aw lock

---------

Co-authored-by: Fabrizio Ferri-Benedetti <fabri.ferribenedetti@elastic.co>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants