Open
Conversation
Mpdreamz
approved these changes
Nov 17, 2025
cotti
reviewed
Nov 19, 2025
| options.TemporalityPreference = MetricReaderTemporalityPreference.Delta; | ||
| }); | ||
|
|
||
| _ = builder.Services.AddOpenTelemetry().UseOtlpExporter(); |
Contributor
There was a problem hiding this comment.
This creates a new OTLP Exporter, breaking integration testing (and I'd assume live).
The reason it creates a new one is that an implicit default ElasticOpenTelemetryOptions has its SkipOtlpExporter set to false. Also, this starts a new OpenTelemetry service which is already defined in the beginning of ConfigureOpenTelemetry, is this wanted?
Contributor
|
Suggestion for ConfigureOpenTelemetry (passes integration): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.