Don't show base version in Applies_to tags if no version is defined#2630
Merged
Don't show base version in Applies_to tags if no version is defined#2630
Conversation
reakaleek
commented
Feb 4, 2026
Mpdreamz
approved these changes
Feb 4, 2026
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Does this also tackle the popovers?
Member
Author
Yes. But I already found a bug. |
…on attributes The Razor template always renders badge-lifecycle-text and badge-version attributes (even when empty), but the test expectations for Serverless GA were missing these required attributes, causing CI failures.
🔍 Preview links for changed docs |
Razor Slices automatically removes empty string attributes from HTML output. Updated test expectations to match actual output by removing badge-lifecycle-text and badge-version attributes when they are empty strings, and removing badge-key when it's not provided (generic product case).
florent-leborgne
approved these changes
Feb 4, 2026
Contributor
florent-leborgne
left a comment
florent-leborgne
left a comment
There was a problem hiding this comment.
Current changes LGTM - I'm wondering about the markdown output since it's no longer showing the base version either // do we anticipate negative effects on version-related accuracy? Or do we need to think of a way to convey that the content from these pages generally applies to users on Elastic v9 unless otherwise specified // Worded in a way that can't be mistaken for "this feature is available in version xxx"
shainaraskas
approved these changes
Feb 4, 2026
Contributor
shainaraskas
left a comment
shainaraskas
left a comment
There was a problem hiding this comment.
same note as florent, but maybe something to deal with separately. lgtm
Mpdreamz
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.