Added support for service.version#168
Merged
eyalkoren merged 4 commits intoelastic:mainfrom Apr 28, 2022
Merged
Conversation
Contributor
Author
|
@eyalkoren I will add support for it in the agent once this is released. |
Contributor
Author
|
@eyalkoren Would you please have a look? |
Contributor
Author
|
ping |
Closed
Contributor
|
@tobiasstadler sorry, we are quite overloaded atm, I hope we have a chance to get to this and additional ecs-logging stuff soon enough 🙏 |
eyalkoren
reviewed
Apr 27, 2022
Contributor
eyalkoren
left a comment
There was a problem hiding this comment.
@tobiasstadler Apologies for the long wait 🙏
Few very minor comments.
Please just bring up to date, then we'll test and merge.
Thanks for your patience!
jul-ecs-formatter/src/main/java/co/elastic/logging/jul/EcsFormatter.java
Outdated
Show resolved
Hide resolved
eyalkoren
approved these changes
Apr 28, 2022
felixbarny
approved these changes
Apr 28, 2022
Contributor
Author
|
Thank You! |
This was referenced Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #132. For the reference, I did not have a look at the implementation in #132.