Open
Conversation
aa1631a to
2e97086
Compare
Contributor
|
Hey @mosche , sorry for the delayed response.
This feels like a very elasticsearch specific edge-case, therefore I'm not sure whether we want to add this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR for discussion.
Some exceptions in Elasticsearch don't contain a stacktrace, e.g. NotMasterException.
For these
error.stack_tracetypically just repeats what's already present inerror.typeanderror.message, having the field doesn't add any value.Can we skip
error.stack_tracein this case?