Skip to content

Fix typo identified in #172 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 7 commits into from
Jun 26, 2025
Merged

Fix typo identified in #172 #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e497f24
Fix typo identified in #172
dliappis Jun 25, 2025
6fdda72
Add 3.8/3.9 compatibility for mypy
dliappis Jun 25, 2025
1f5f274
Fix lint
dliappis Jun 25, 2025
8727fb1
Also fix precommit and old mypy
dliappis Jun 25, 2025
bf2123b
Update ecs_logging/_stdlib.py
xrmx Jun 26, 2025
27a059e
Update ecs_logging/_stdlib.py
xrmx Jun 26, 2025
adf4b94
Merge branch 'main' into fix-mypy-again
xrmx Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
hooks:
- id: check-bash-syntax
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.910
rev: v1.16.1
Copy link
Contributor Author

@dliappis dliappis Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that we are currently installing the latest version of mypy when executing the various Python 3.x tests using nox (e.g. see https://github.com/elastic/ecs-logging-python/blob/main/noxfile.py#L54) hence there was a discrepancy here when running precommit tests, that was surfacing non-existent errors.

hooks:
- id: mypy
args:
Expand Down
7 changes: 1 addition & 6 deletions ecs_logging/_stdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
_LOGRECORD_DIR = set()


def _converter(secs: Optional[float] = None) -> time.struct_time:
return time.gmtime(secs)


class StdlibFormatter(logging.Formatter):
"""ECS Formatter for the standard library ``logging`` module"""

Expand Down Expand Up @@ -77,8 +73,7 @@ class StdlibFormatter(logging.Formatter):
"process",
"message",
} | _LOGRECORD_DIR

convert = _converter
converter: Callable[[Optional[float]], time.struct_time] = staticmethod(time.gmtime)

def __init__(
self,
Expand Down