Remove .log from event.dataset

[basepi]

Fixes some test issues caused by upstream release 6.5.0 of the Python agent

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-05T20:04:41.057+0000

• Duration: 9 min 43 sec

• Commit: 28c102a

Test stats 🧪

Test	Results
Failed	0
Passed	205
Skipped	4
Total	209

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[basepi]

/test

[basepi]

As an aside I have no idea how to fix these terrible upstream deps between the agent and this logging library. I think elastic/apm-agent-python#1352 is also likely to cause test failures, but we can't actually fix them until there's a new release. Edit: actually I don't think it will cause test failures, but this still remains a bit of a problem.

I suppose we could pin our tests to master instead of the latest release... 🤔

What do you think @sethmlarson @beniwohli ?

[beniwohli]

Would it make sense to run the ecs-logging test suite as part of the agent tests? Maybe as an allowed failure, so we are aware that things are going to break, but it's not holding up the PR merge

[sethmlarson]

@beniwohli 100% agree these two components should be tested together regularly.

[basepi]

The robots team implemented Beni's recommendation here: #64