[CI] Always test against elastic-apm @ master#68
Merged
basepi merged 3 commits intoelastic:masterfrom Oct 14, 2021
Merged
Conversation
…hed and test it with the master branch (elastic#64)" This reverts commit 9f35b52.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing against both
masterand the latest release seemed like a good idea. However, when there are changes inelastic-apmthat make these tests fail, you can't fix themasterfailures without causing failures against the latest release.This PR reverts #64 and then moves to always testing against
elastic-apm @ master. Going forward, we'll releaseecs-logging-pythonwhenever we releaseelastic-apmto prevent incompatibilities with the latest release.The tests on this PR will likely fail (due to the currently-failing
master-targeted tests that I'm working on fixing shortly).