Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@benhowes
Copy link

@benhowes benhowes commented May 20, 2020

This PR simply upgrades to modern syntax, which is deprecated as of python3.8 (and available as of 3.6)

  • @asyncio.coroutine -> async def
  • yield from -> await

Neatly described in this SO answer https://stackoverflow.com/a/44273861

@cla-checker-service
Copy link

cla-checker-service bot commented May 20, 2020

❌ Author of the following commits did not sign a Contributor Agreement:
0c12076, dbbe5c4

Please, read and sign the above mentioned agreement if you want to contribute to this project

@benhowes benhowes changed the title Drop support for python 3.5 Update to async/await syntax May 20, 2020
@sethmlarson
Copy link
Contributor

Thank you for the interest!

This work is already being done as a part of migrating AsyncElasticsearch to the main elasticsearch package: elastic/elasticsearch-py#1232
Will be landing soon so I'll close this PR as duplicate.

@benhowes
Copy link
Author

Ah perfect, thanks!

@benhowes benhowes deleted the refactor/remove-coroutine-decorators branch May 20, 2020 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants