Skip to content

Add AsyncTransport #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethmlarson merged 4 commits into from
May 19, 2020
Merged

Add AsyncTransport #1235

sethmlarson merged 4 commits into from
May 19, 2020

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented May 14, 2020

This PR adds AsyncTransport to the AIOHttpConnection branch as it depends on the async http connection being available to test.

@sethmlarson sethmlarson mentioned this pull request May 14, 2020
Closed
@sethmlarson
Copy link
Contributor Author

sethmlarson commented May 15, 2020 •
edited
Loading

  • CI appears to be failing one test randomly due to the random order of tasks returning in the sniff task, will see if I can make the task order consistent.

vEpiphyte
vEpiphyte reviewed May 16, 2020
View reviewed changes
danielmitterdorfer
danielmitterdorfer reviewed May 18, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment about closing the transport but apart from that it looks great.

@sethmlarson sethmlarson merged commit a65ff81 into aiohttp May 19, 2020
@sethmlarson sethmlarson deleted the async-transport branch May 19, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer left review comments

+1 more reviewer

@vEpiphyte vEpiphyte vEpiphyte left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sethmlarson @danielmitterdorfer @vEpiphyte