Skip to content

Switch to new API generator #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethmlarson merged 6 commits into from
Nov 19, 2021
Merged

Switch to new API generator #1802

sethmlarson merged 6 commits into from
Nov 19, 2021

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Nov 15, 2021 •
edited
Loading

  • API generator now creates the complete function signature of each parameter
  • Parameters are serialized inline instead of within a decorator
  • Type hints aren't generated into separate .pyi files, instead are inline
  • Changes API function decorator to expand body and params instead of old behavior of pulling parameters into body and params.
  • Changed the sorting of APIs within a file to be alphabetical instead of based on previous file.
  • Deletes the old API generator from utils/.

Closes #1680

@sethmlarson sethmlarson mentioned this pull request Nov 15, 2021
Closed
13 tasks
@sethmlarson sethmlarson force-pushed the new-api-gen branch 4 times, most recently from 772f21d to 48cce99 Compare November 16, 2021 17:59
@sethmlarson sethmlarson force-pushed the new-api-gen branch 3 times, most recently from 5f97af0 to 8c26f6c Compare November 16, 2021 23:39
@sethmlarson sethmlarson force-pushed the new-api-gen branch 3 times, most recently from cfd032d to aa63e82 Compare November 18, 2021 15:27
@sethmlarson sethmlarson reopened this Nov 18, 2021
@sethmlarson
Copy link
Contributor Author

sethmlarson commented Nov 18, 2021

Published a fix in elastic-transport 8.0.0-alpha5.

@sethmlarson sethmlarson merged commit 7705a52 into main Nov 19, 2021
@sethmlarson sethmlarson deleted the new-api-gen branch November 19, 2021 17:38
@github-actions github-actions bot mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose JSON body fields as typed parameters

2 participants

@sethmlarson