[Redis] Add and update metrics fields for Redis 7.x and 8.x#16732
[Redis] Add and update metrics fields for Redis 7.x and 8.x#16732giorgi-imerlishvili-elastic wants to merge 12 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
| skip: | ||
| reason: Test is skipped for now since it will fail on Redis 7.x and 8.x due to the issue #43887 | ||
| link: https://github.com/elastic/beats/issues/43887 No newline at end of file |
There was a problem hiding this comment.
Didn't you fix this in elastic/beats#47971 ? Why skipping?
There was a problem hiding this comment.
@mykola-elastic I merged that PR yesterday, it's merged in main branch. Doesn't it need some time to apply to the SANPSHOTS which are used for development and in CI?
There was a problem hiding this comment.
Similar PR to this one: https://github.com/elastic/integrations/pull/16680/files
It adds the field which was added and backported to beats but it updated the kibana.version. (See PR description and changes).
So, basically, it seems that you have to change kibana.version too to the latest as the subexpiry was only added to the main.
Also, we might need to backport the PR elastic/beats#47971 too?
Is my logic correct @ishleenk17 @shmsr ?
There was a problem hiding this comment.
Any concerns on this one ? @giorgi-imerlishvili-elastic
There was a problem hiding this comment.
@ishleenk17 my concern is that this fix might need to be backported, but I'm not sure which versions it should apply to—only 9.x, or earlier versions as well. The fix is already merged into main, which corresponds to the current 9.4 version.
There was a problem hiding this comment.
@giorgi-imerlishvili-elastic : Since this change enables Beats to support Redis versions > 7.x, I'd classify this as an enhancement rather than a bug fix. Given that, I recommend including it only in the main release (9.4.0) without backporting. We can revisit backporting if there's specific customer demand, but our general practice is to reserve backports for bug fixes, not enhancements.
andrewkroh
added
Integration:redis
|
@giorgi-imerlishvili-elastic : Can we please complete this by adding the missing fields too. |
# Conflicts: # packages/redis/_dev/deploy/docker/Dockerfile # packages/redis/_dev/deploy/docker/docker-compose.yml # packages/redis/data_stream/info/_dev/test/system/test-default-config.yml
remove skip from keyspace data stream system test
💔 Build Failed
Failed CI StepsHistory
|
| - observability | ||
| conditions: | ||
| kibana: | ||
| version: "^8.13.0 || ^9.0.0" |
There was a problem hiding this comment.
Future reminder: before merging this, we might need to review which versions should be specified in kibana.version.
cc: @ishleenk17
|
@giorgi-imerlishvili-elastic see if the PR title and descriptions syncs out with the beats. Should be consistent. |
7 participants
Proposed commit message
Add and update metrics fields for Redis 7.x and 8.x
Add system test for info data stream
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots