Conversation
1. Fixed Duration Field Types Changed collection_interval and initial_delay from type: text to type: duration in manifest.yml. 2. Added Missing TLS Configuration Options Added to manifest.yml and input.yml.hbs: tls_min_version - Minimum TLS version (1.0, 1.1, 1.2, 1.3) tls_max_version - Maximum TLS version tls_include_system_ca_certs_pool - Include system CA pool alongside custom CA 3. Added Dialer Timeout Option Added dialer_timeout (duration type) for configuring connection timeout. 4. Updated Documentation Updated both docs/README.md and _dev/build/docs/README.md to document the new fields: Connection Settings table - Added Dialer Timeout row TLS Settings table - Added: TLS Min Version TLS Max Version Include System CA Certs Pool
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Two consistency issues found:
-
Owner mismatch: The CODEOWNERS file assigns
@elastic/ecosystembut manifest.yml declareselastic/obs-infraobs-integrationsas the GitHub owner. These should be aligned. -
Changelog link: References PR #17097 instead of this PR (#17281).
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
mrodm
force-pushed
the
add-redis-otel-input-package
branch
from
b03d87c to
2b9ad83
Compare
💚 Build Succeeded
History
cc @mrodm |
|
@claude please update the logo of this Given the logo found here (https://github.com/elastic/integrations/blob/641ca791261e11518c028aea25e578fa293b6c5e/packages/redis/img/logo_redis.svg) you need to join the OTEL logo to the right bottom corner. The original OTEL icon is https://github.com/open-telemetry/opentelemetry.io/blob/main/iconography/32x32/Open_Telemetry.svg. Requirements for the updated logo for this package:
Some example: https://github.com/elastic/integrations/blob/main/packages/iis_input_otel/img/iis_otellogo.svg |
|
Claude finished @mrodm's task in 1m 18s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: --- | Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
@claude please update the logo of this Given the logo found here (https://github.com/elastic/integrations/blob/641ca791261e11518c028aea25e578fa293b6c5e/packages/redis/img/logo_redis.svg) you need to join the OTEL logo to the right bottom corner. The original OTEL icon is https://github.com/open-telemetry/opentelemetry.io/blob/main/iconography/32x32/Open_Telemetry.svg. Requirements for the updated logo for this package:
Some examples in other packages: |
|
Claude finished @mrodm's task in 4m 2s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: --- | Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
@claude please update the logo of this Given the logo found here (https://github.com/elastic/integrations/blob/641ca791261e11518c028aea25e578fa293b6c5e/packages/redis/img/logo_redis.svg) you need to join the OTEL logo to the right bottom corner. The original OTEL icon is https://github.com/open-telemetry/opentelemetry.io/blob/main/iconography/32x32/Open_Telemetry.svg. Requirements for the updated logo for this package:
Some examples in other packages: |
|
Claude finished @mrodm's task in 6m 39s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Claude finished @mrodm's task in 2m 28s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: --- | Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Claude finished @mrodm's task in 1m 40s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
andrewkroh
added
New Integration
|
Claude finished @mrodm's task in 2m 45s —— View job Updating Redis OTel Package Logo
Summary: Updated the
Commit: Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
There was a problem hiding this comment.
The password field uses secret: true, but Fleet Server has a known issue (#6277) where secrets in OTel configurations aren't properly resolved. The prometheus_input_otel package explicitly uses secret: false with a TODO comment referencing this issue. Until Fleet Server resolves this, the password may not be correctly substituted at runtime.
Consider following the pattern from prometheus_input_otel and setting secret: false with a TODO comment to re-enable once the issue is fixed.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| required: false | ||
| title: Password | ||
| description: The password used to access the Redis instance; must match the password specified in the requirepass server configuration option in Redis <6.0, or the user's password when using the Redis ACL system in Redis 6.0+. | ||
| secret: true |
There was a problem hiding this comment.
🟠 HIGH Secret handling may fail with Fleet Server
Why: Fleet Server has a known issue (#6277) where secrets in OTel configurations aren't properly resolved. Other OTel input packages set secret: false as a workaround.
| secret: true | |
| secret: false |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| description: Override the virtual host name of authority in TLS requests. | ||
| show_user: false | ||
| - name: tls_min_version | ||
| type: text |
There was a problem hiding this comment.
⚪ LOW Consider using select type for TLS version fields
Why: Using select type with predefined options (like transport field) would provide better user experience and prevent invalid inputs.
| type: text | |
| type: select | |
| required: false | |
| title: TLS Min Version | |
| description: Minimum acceptable TLS version. | |
| multi: false | |
| options: | |
| - text: "TLS 1.0" | |
| value: "1.0" | |
| - text: "TLS 1.1" | |
| value: "1.1" | |
| - text: "TLS 1.2" | |
| value: "1.2" | |
| - text: "TLS 1.3" | |
| value: "1.3" |
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
5 participants
Proposed commit message
This PR adds a new Redis OpenTelemetry Input Package (
redis_input_otel) that enables Elastic users to collect metrics from Redis servers using the OpenTelemetry Collector's redisreceiver through the EDOT (Elastic Distribution of OpenTelemetry) collector.New Package:
redis_input_otelThe package provides:
Configuration Options
localhost:6379tcptcporunix)true10s1sChecklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana's Dashboard good practicesAuthor's Checklist
How to test this PR locally
Related issues
Screenshots