Rename __private to __

[Veetaha]

Unfortunatelly, clippy doesn't trim paths (rust-lang/rust-clippy#7798), which makes bon::__private:: prefix appear in error messages. This will look ugly to people looking at errors from clippy, as if bon leaks some impl details...

To reduce some of that impression I'm renaming __private to just __ which makes the error messages shorter, even though makes it less clear that the module shouldn't be used directly, but I think we already have enough indication for that given the exotic naming of the module and the deprecation warnings users will see if they try to use the symbols from that module

Summary by CodeRabbit

• Bug Fixes

  • Resolved compilation errors related to incorrect attribute usage and missing trait implementations for the NoTraitImpls struct.
  • Corrected formatting of the bounds attribute to use parentheses instead of curly braces.

• New Features

  • Added Clone and Debug trait implementations to the NoTraitImpls struct, improving its usability in various contexts.

• Chores

  • Updated the file path for the derives.rs file, indicating project restructuring.

[coderabbitai]

Walkthrough

The changes involve modifications to the NoTraitImpls struct in the attr_derive.rs file, addressing multiple compilation errors. Key updates include correcting the usage of attributes, adding necessary trait implementations for Clone and Debug, and fixing formatting issues with the bounds attribute. Additionally, the file path for derives.rs has been altered, indicating a potential restructuring within the project.

Changes

File Path	Change Summary
tests/integration/ui/compile_fail/attr_derive.rs	Updated NoTraitImpls struct to derive Clone and Debug traits; corrected attribute usage and formatting issues.
src/private/derives.rs → src//derives.rs	File path modified, indicating a restructuring of the project.

Sequence Diagram(s)

sequenceDiagram
    participant Compiler
    participant NoTraitImpls
    participant attr_derive.rs

    Compiler->>attr_derive.rs: Check for trait implementations
    attr_derive.rs->>NoTraitImpls: Verify attributes and traits
    NoTraitImpls-->>attr_derive.rs: Missing implementations (Clone, Debug)
    attr_derive.rs->>Compiler: Report errors
    Compiler-->>attr_derive.rs: Compilation failed

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 54eae60 and 791ef53.

⛔ Files ignored due to path filters (11)

• bon-macros/src/builder/builder_gen/builder_derives.rs is excluded by !**/*.rs
• bon-macros/src/builder/builder_gen/mod.rs is excluded by !**/*.rs
• bon-macros/src/builder/builder_gen/state_mod.rs is excluded by !**/*.rs
• bon-macros/src/util/ide.rs is excluded by !**/*.rs
• bon/src/__/cfg_eval.rs is excluded by !**/*.rs
• bon/src/__/derives.rs is excluded by !**/*.rs
• bon/src/__/ide.rs is excluded by !**/*.rs
• bon/src/__/mod.rs is excluded by !**/*.rs
• bon/src/builder_state.rs is excluded by !**/*.rs
• bon/src/collections.rs is excluded by !**/*.rs
• bon/src/lib.rs is excluded by !**/*.rs

📒 Files selected for processing (1)

• bon/tests/integration/ui/compile_fail/attr_derive.stderr (22 hunks)

🔇 Additional comments (4)

bon/tests/integration/ui/compile_fail/attr_derive.stderr (4)

Line range hint 58-66: LGTM: Intentional compile failure test cases

These attribute syntax errors are intentionally crafted test cases in the compile_fail directory to verify proper error handling.

---

38-38: Path changes successfully improve error message readability

The renaming from __private to __ is correctly reflected in the error messages, making them more concise while maintaining their effectiveness. This change successfully addresses the PR's objective of improving error message readability.

Also applies to: 72-72, 91-91, 177-177, 194-194, 211-211, 230-230, 249-249, 268-268, 287-287, 322-322, 339-339, 356-356, 375-375, 389-389, 408-408, 427-427, 446-446

---

Line range hint 9-50: LGTM: Comprehensive trait implementation test cases

The test cases effectively verify that:

1. The compiler correctly identifies missing trait implementations
2. Appropriate error messages are generated with helpful suggestions
3. The errors are consistent across different usage contexts (direct usage, optional fields, etc.)

---

Line range hint 1-446: Verify consistent path updates across the codebase

Let's ensure the renaming from __private to __ is consistently applied.

✅ Verification successful

Based on the shell script results, I can now provide a final response:

Path change from __private to __ is correctly implemented

The codebase shows consistent usage of the new __ path in error messages and actual code. The only remaining occurrences of __private are in the macro generation code where it's used as a prefix for generated identifiers, which is intentional and unrelated to the path change:

• All references to derives.rs consistently use src/__/derives.rs
• The actual derives.rs file is found and contains the expected utility functions
• The only remaining __private occurrences are in bon-macros/src/builder/builder_gen/ where they are intentionally used for identifier generation

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining occurrences of __private in the codebase
# Expected: No occurrences of __private should be found

echo "Checking for remaining occurrences of __private..."
rg "__private" --type rust

echo "Verifying all occurrences of the new __ path..."
rg "src/__/" --type rust

Length of output: 523

---

Script:

#!/bin/bash
# Let's check for any references to derives.rs in the codebase
echo "Checking for references to derives.rs..."
rg -A 2 "derives\.rs"

# Check for any paths containing __
echo "Checking for paths containing __..."
rg -l "__/"

# Check the actual content of any derives.rs files
echo "Looking for derives.rs files..."
fd "derives.rs" --type f --exec cat {}

Length of output: 16130

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.