Add support for derive(IntoFuture(Box))#322
Merged
Veetaha merged 20 commits intoelastio:masterfrom Aug 9, 2025
Merged
Conversation
Use `#[tokio::main]` instead of `tokio_test` in the doc example to make it a more real-world-looking. Also strip the `std::io::Result` for simplicity. Async functions are usually fallible, but for the purposes of an example, it's fine to simplify it. Besides, to my personal mind `std::io::Error` is usually a bad pattern as it returns a non-descriptive error message. I'd promote `anyhow` instead in the docs, but here I think making it infallible is okay.
…t, so it was missed
Collaborator
|
Thanks for the contribution. I pushed some improvements to this PR as well as support for non- |
Veetaha
approved these changes
Aug 9, 2025
Contributor
Author
@Veetaha, thank you for the follow-up work and merging the PR. 7c9f53a looks like it addressed a significant omission, in particular. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #314.
This allows for a derivation of the
IntoFuturetrait which enables a pattern by which a builder holding all required properties and ready to be finalised, can beawaited on to produce the final result asynchronously.