Set lowerbound of rustversion of to v1.0.19#336
Merged
Veetaha merged 1 commit intoelastio:masterfrom Sep 2, 2025
Merged
Conversation
I got the following error in Iceberg-Rust:
```
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/bon-macros-3.7.0/src/builder/builder_gen/getters.rs:227:46
|
227 | let module = if rustversion::cfg!(since(1.64.0)) {
| ^^^ could not find `cfg` in `rustversion`
```
Which depends on Avro-rs, and Avro-rs depends on Bon.
It looks like `rustversion::cfg!` has been added in 1.0.19:
- https://crates.io/crates/rustversion/1.0.19
- https://crates.io/crates/rustversion/1.0.18
Veetaha
approved these changes
Sep 2, 2025
Collaborator
There was a problem hiding this comment.
Thank you for the fix! I double checked with cargo +nightly update -Z minimal-versions and this seems to be the only offender. Will release this as 3.7.2.
UPD: release is done.
Contributor
Author
|
Wow, thanks for the quick follow-up, much appreciated 👍 |
Fokko
added a commit
to Fokko/avro-rs
that referenced
this pull request
Sep 2, 2025
Bon had a faulty lower-bound, see: elastio/bon#336
martin-g
pushed a commit
to apache/avro-rs
that referenced
this pull request
Sep 2, 2025
Bon had a faulty lower-bound, see: elastio/bon#336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the following error in Iceberg-Rust:
Which depends on Avro-rs, and Avro-rs depends on Bon.
It looks like
rustversion::cfg!has been added in 1.0.19: