Fix TestNoProxyHeaders and TestNoProxyHeadersHttps tests#215
Closed
erikdubbelboer wants to merge 1 commit intoelazarl:masterfrom
Closed
Fix TestNoProxyHeaders and TestNoProxyHeadersHttps tests#215erikdubbelboer wants to merge 1 commit intoelazarl:masterfrom
erikdubbelboer wants to merge 1 commit intoelazarl:masterfrom
Conversation
When the original request has a Connection: close header Go sets r.Close to true. When this is true Go adds the Connection: close header to the outgoing request even if the header was removed. Fixes elazarl#92
Author
|
@elazarl no? |
Author
|
Tests are still failing... |
Collaborator
|
Tests are not failing anymore, closing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the original request has a
Connection: closeheader Go setsr.Closeto true. When this is true Go adds theConnection: closeheader to the outgoing request even if the header was removed.Fixes #92
This does mean that there is currently no way to make goproxy set a
Connection: closeheader for its outgoing requests. I guess this could be made an option inProxyCtxso you can change it in a request handler.