Conversation
friederbluemle
left a comment
friederbluemle
left a comment
There was a problem hiding this comment.
Changes look good overall. The Upgrade gradle commit was missing some updates to the wrapper scripts - something that the wrapper task does (Android Studio won't do it). I opened a quick PR with only those changes here: #152
So after rebasing, you can exclude the file from the commit, and also reword it to Update Android Gradle plugin to 4.0.1
| props.putAll(data); | ||
| } | ||
| mMiniAppView.setAppProperties(props); | ||
| ((ReactRootView)mMiniAppView).setAppProperties(props); |
| proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' | ||
| } | ||
| debug { | ||
| multiDexEnabled true |
There was a problem hiding this comment.
Yes, required for instrumentation testing
There was a problem hiding this comment.
But this enables it not only for testing... Why is it required for instrumentation testing?
|
|
||
| @Test | ||
| public void testRootComponentRendering() { | ||
| Assert.assertNotNull(rule); |
There was a problem hiding this comment.
Best practice to use static imports for things like assertNotNull etc. (Just like you've already added a static import for fail) - It makes these lines shorter and easier to read.
android/lib/build.gradle
Outdated
| androidTestImplementation 'androidx.test.ext:junit:1.1.1' | ||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0' | ||
| androidTestImplementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0' | ||
| androidTestImplementation 'com.android.support:multidex:1.0.3' |
There was a problem hiding this comment.
you can use "androidx.multidex:multidex:2.0.1" instead
This helps React Native components to send navigate requests when backgrounded
deepueg
force-pushed
the
add-tests
branch
2 times, most recently
from
89b64f0 to
5591e00
Compare
4 participants
No description provided.