fix: use siso for chrome target instead of reclient#768
Open
mitchchn wants to merge 2 commits intoelectron:mainfrom
Open
fix: use siso for chrome target instead of reclient#768mitchchn wants to merge 2 commits intoelectron:mainfrom
mitchchn wants to merge 2 commits intoelectron:mainfrom
Conversation
dsanders11
changed the title
dsanders11
approved these changes
Oct 27, 2025
Member
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
Updated the title to pass the semantic PR title check.
I think we probably want to just rip out the reclient stuff all together soon, but since that's going to be a large PR, I'm happy to accept this small focused change for now. 👍
codebytere
approved these changes
Oct 28, 2025
jkleinsc
requested changes
Oct 28, 2025
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
That I know of siso still uses the reclient configs, so we should still leave this code in.
jkleinsc
requested changes
Oct 28, 2025
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
We still need the reclient_cfgs, they are referenced in siso configs: https://source.chromium.org/chromium/chromium/src/+/main:build/config/siso/clang_windows.star;l=33?q=build%2Fconfig%2Fsiso%2Fclang_windows.star&ss=chromium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.