feat: add support for packaging fiddles as ASAR using @electron/asar#138
Conversation
d24be4b to
c97f17c
Compare
c97f17c to
c791fab
Compare
|
Hi @erickzhao, just a friendly reminder for a review when you have a moment. |
|
Pushed up a few commits here due to the main branch being fixed (3b420d8) and to re-commit the lockfile due to our internal policies around that. |
|
This looks like a good start, but I think some changes are needed before we can merge. I've left a comment about the |
Added a test for |
dsanders11
left a comment
There was a problem hiding this comment.
This is close, just a few more comments. Be sure to run yarn docs after the final changes to ensure that etc/fiddle-core.api.md is up-to-date.
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
optionparameter inFiddleFactory.create()method.{ packAsAsar: true }is passed asoption, the fiddle is packaged as an ASAR using@electron/asar.Closes #100