Draft
Conversation
339c4e0 to
c4cd192
Compare
f489038 to
9ec848d
Compare
9ec848d to
62bc0dd
Compare
beec644 to
9a9a873
Compare
1f2dded to
7cd43bc
Compare
7cd43bc to
0d1af20
Compare
6d40ec0 to
8ab847e
Compare
71defdf to
61281ed
Compare
codebytere
approved these changes
May 3, 2023
Member
codebytere
left a comment
There was a problem hiding this comment.
Looks generally good to me! A few comments but they're non-blocking.
dsanders11
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Fiddle snap distributable and tests out our CI setup for snap development.
The current snap binary can be installed by running
sudo snap install --dangerous <binary-name>. If we want to upload the build to the official Snap store, we'll have to create an account and vet the binary there. Minus Snap store submission, this PR should be ready for review.Improvement list: