Skip to content

fix: improve behavior of setting sync between windows#1386

Merged
dsanders11 merged 3 commits intomainfrom
fix-setting-sync-key
Jul 11, 2023
Merged

fix: improve behavior of setting sync between windows#1386
dsanders11 merged 3 commits intomainfrom
fix-setting-sync-key

Conversation

@dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jul 3, 2023

Follow-up to #1376 which fixes a few bugs:

  • Don't warn when WindowSpecificSetting settings are touched
  • Fix cases where the enum value does not match the enum key
  • Better handle several keys which do not exist on AppState
  • Sync local versions properly between windows
  • Update some JSDoc types which were changed in fix: update settings in all open windows #1376

cc @erikian

@dsanders11 dsanders11 requested review from a team and codebytere as code owners July 3, 2023 20:19
dsanders11 and others added 2 commits July 3, 2023 14:56
Co-authored-by: Erik Moura <erikian@erikian.dev>
@dsanders11 dsanders11 merged commit 92480ac into main Jul 11, 2023
@dsanders11 dsanders11 deleted the fix-setting-sync-key branch July 11, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants