fix: better handle env variables and execution flags settings changes#1410
Merged
dsanders11 merged 1 commit intomainfrom Jul 19, 2023
Merged
fix: better handle env variables and execution flags settings changes#1410dsanders11 merged 1 commit intomainfrom
dsanders11 merged 1 commit intomainfrom
Conversation
codebytere
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The execution settings panel broke as a result of #1389. Making
SettingItemTypea proper enum broke the code which iterates over the values, as TypeScript is now creating a reverse mapping as well, which meansObject.valueswas returning keys as well.Refactored so that iterating the enum values is not necessary, and probably a bit better implementation as a result. It's still kind of funky how this state is stored on both
AppStateandExecutionSettingsState, but this fixes the immediate breakage.