fix: uncaught error when renaming file failed

[gaspardruan]

Before

appState.editorMosaic.remove(editorId);
appState.editorMosaic.addNewFile(id, contents);
if (visible) appState.editorMosaic.show(id);

If the new file name already existed or was another main entry point file, addNewFile() would throw error. Then, remove() would be executed but addNewFile() not, which means renaming file failure would lead to the deletion of the file.

Now

try {
    appState.editorMosaic.addNewFile(id, contents);
    appState.editorMosaic.remove(editorId);

    if (visible) appState.editorMosaic.show(id);
} catch (err) {
    appState.showErrorDialog(err.message);
}

[codebytere]

Thanks for fixing this! We should also add a test to confirm that this fixes the issue.

You'll want to add the tests to this file, using a similar approach as the fails if trying to rename an editor to an invalid value test there.

[codebytere]

thanks!!

[coveralls]

coverage: 87.361% (+0.1%) from 87.245%
when pulling b7e597d on gaspardruan:fix-rename-file
into 23eb6a7 on electron:main.

[dsanders11]

Thanks @gaspardruan! Another quality PR. 🙂