feat: improve error dialog when gist publish is failing#1727
Open
vhashimotoo wants to merge 1 commit intoelectron:mainfrom
Open
feat: improve error dialog when gist publish is failing#1727vhashimotoo wants to merge 1 commit intoelectron:mainfrom
vhashimotoo wants to merge 1 commit intoelectron:mainfrom
Conversation
vhashimotoo
force-pushed
the
vh/improve-gist-publish-error
branch
from
fabea90 to
f4a2c74
Compare
codebytere
requested changes
Jul 31, 2025
Member
codebytere
left a comment
codebytere
left a comment
There was a problem hiding this comment.
I'm not sure I think we should always show an update token button for failure dialogs - there are a lot of reasons publish could fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1549
This PR improves the UX of the error dialog that is showed when the user tries to perform actions (publish/update/delete) with a Gist with invalid credentials (or with some other error). This updates the dialog and adds the button that will move the user to the settings page and opens the token update window when the error is related to bad credentials and shows the standard error dialog if something else happened.