Skip to content

Enables Fiddles That Capture Audio via Apple's New CoreAudio Tap API#1844

Open
Bug-Reaper wants to merge 1 commit intoelectron:mainfrom
Bug-Reaper:bug-reaper/core-audio-tap-api
Open

Enables Fiddles That Capture Audio via Apple's New CoreAudio Tap API#1844
Bug-Reaper wants to merge 1 commit intoelectron:mainfrom
Bug-Reaper:bug-reaper/core-audio-tap-api

Conversation

@Bug-Reaper
Copy link

Hey there,

Big fan of this app, it was really useful on my most recent adventure. Let me be the first to introduce you to:

Core Audio Tap API

Apple introduced a new permission to be able to use their latest API for audio-capture available since some version of macOS 14. In line with enabling other permissions like web-cam and microphone (which enable audio capture through a different API anyways) we should also include this new permission to our Fiddle's info.plist.

This PR adds the proper usageDescription to the forge-script so at build time the new flag is added to Fiddle's info.plist


I've spent the last 5 days reviewing C++/Objective-C Chromium source to hone in on why my DesktopAudioCapture broke on an electron version update.

It is in-fact chromium started using this new Core Audio Tap API and has no fallback to the old API if the new one fails. Frustratingly, the error is silent from the electron-side and it fails even though a valid permission for audio-capture exists under a different API.

This PR is important to resolve aforementioned issues for Fiddler's attempting to use desktop audio on electron versions 39.0.0-beta.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants