Delete .lproj files after package

[linonetwo]

Preflight Checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

I hope I can delete all .lproj files, because they seems useless (I'm using i18next npm package instead)

Proposed Solution

Follow https://ganeshrvel.medium.com/electron-builder-afterpack-configuration-5c2c986be665

But this won't call scripts/afterPack.js

"config": {
    "forge": {
      "packagerConfig": {
        "icon": "build-resources/icon.icns",
        "asar": {
          "unpack": "**/.webpack/main/*.worker.*"
        },
        "extraResource": [
          "localization",
          "template/wiki"
        ],
        "mac": {
          "category": "productivity",
          "target": "dmg",
          "icon": "build-resources/icon.icns",
          "electronLanguages": [
            "zh_CN",
            "en",
            "ja"
          ]
        },
        "postPackage": "scripts/afterPack.js"
      },
      "makers": [

Alternatives Considered

Try other hooks likes afterCopy

Additional Information

I'm putting my own things into resources folder, and checking them is hard because there are too many annoying lproj files, and they are not related to my project.

[linonetwo]

Solution:

/**
 * Remove all .lproj files
 * Based on https://ganeshrvel.medium.com/electron-builder-afterpack-configuration-5c2c986be665
 * Adapted for electron forge https://github.com/electron-userland/electron-forge/issues/2248
 */
const path = require('path');
const glob = require('glob');
const fs = require('fs-extra');

/**
 * Specific which lproj you want to keep
 */
const keepingLprojRegEx = /(en)\.lproj/g;

/**
 *
 * @param {*} buildPath /var/folders/qj/7j0zx32d0l75zmnrl1w3m3b80000gn/T/electron-packager/darwin-x64/TiddlyGit-darwin-x64/Electron.app/Contents/Resources/app
 * @param {*} electronVersion 12.0.6
 * @param {*} platform darwin
 * @param {*} arch x64
 * @returns
 */
exports.default = async (buildPath, electronVersion, platform, arch, callback) => {
  const cwd = path.join(buildPath, '..');
  const lproj = glob.sync('*.lproj', { cwd });
  const pathsToRemove = lproj.filter((dir) => !keepingLprojRegEx.test(dir)).map((dir) => path.join(cwd, dir));
  if (platform === 'darwin') {
    await Promise.all(pathsToRemove.map((dir) => fs.remove(dir)));
  }
  callback();
};

[linonetwo]

use afterPrune

  "config": {
    "forge": {
      "packagerConfig": {
        "icon": "build-resources/icon.icns",
        "asar": {
          "unpack": "**/.webpack/main/*.worker.*"
        },
        "extraResource": [
          "localization",
          "template/wiki"
        ],
        "mac": {
          "category": "productivity",
          "target": "dmg",
          "icon": "build-resources/icon.icns",
          "electronLanguages": [
            "zh_CN",
            "en",
            "ja"
          ]
        },
        "afterPrune": ["scripts/afterPack.js"]
      },
      "makers": [

[malept]

For clarification for folks coming to this issue in the future:

• there is currently no mac section of packagerConfig
• languages can be adjusted via the electron-packager-languages plugin, which, as of this comment, you would use in a packagerAfterCopy hook.

For future questions about using Electron Forge, please use one of the community forums, including the Electron Discord server.