fix(template-typescript-webpack): properly load forge.config.ts#3016
Merged
VerteDinde merged 1 commit intomainfrom Oct 28, 2022
Merged
fix(template-typescript-webpack): properly load forge.config.ts#3016VerteDinde merged 1 commit intomainfrom
forge.config.ts#3016VerteDinde merged 1 commit intomainfrom
Conversation
forge.config.ts
erickzhao
commented
Oct 28, 2022
| "node-loader": "^2.0.0", | ||
| "style-loader": "^3.0.0", | ||
| "ts-loader": "^9.2.2", | ||
| "ts-node": "^10.0.0", |
Member
Author
There was a problem hiding this comment.
This line this the only change. The rest of the diff is alphabetization.
VerteDinde
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Our usage of
rechoirintroduced in #2993 was actually broken. Running the TypeScript Webpack template yields the following error when attempting to loadforge.config.tswithrechoir.Repro
Run the
initcommand with--template=typescript-webpackand attempt to runyarn start.Solution
Add
ts-nodeas a dev dependency for the template.Rationale
As per the rechoir docs, rechoir needs a local installation of the ts -> js transformer to run.
A similar error was filed for
rechoirusage in the webpack CLI in the past (webpack/webpack-cli#1993) where the solution was to installts-node.