refactor: use listr2 instead of async-ora#3022
Merged
MarshallOfSound merged 11 commits intomainfrom Oct 31, 2022
Merged
Conversation
MarshallOfSound
commented
Oct 30, 2022
VerteDinde
approved these changes
Oct 31, 2022
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This swap does a few cool things:
This refactor can be done bit-by-bit, this PR tackles the top level
checkSystemcommand and theinit+startsubcommands. Other commands can be ported ad-hoc with the exception of packager which shouldn't be ported until #3006 lands or is in a state to be cherry-picked.api/corealready depended onlistr2as well so this doesn't add anything to our dependency tree.Screenshots
Init with
template-webpackStart with native module failure
Start with
plugin-webpack