fix(publish): ignore unnecessary files when publishing to npm#3024
Merged
VerteDinde merged 1 commit intoelectron:mainfrom Oct 31, 2022
Merged
Conversation
VerteDinde
approved these changes
Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Currently, a large number of source/development files (
.ts/.map/etc.) from most packages is being published to npm.The
plugin-webpackpackage is even publishing its entiretestfolder with a test app, including itsnode_modules:This PR addresses the problem by writing a
.npmignorefile to each package folder before publishing, and then removing the file afterwards..ts(except.d.tstype definitions),tsconfig.json,.mapand.tsbuildinfofiles, as well as any/testfolders, are now ignored.Since the
.gitignorein the project root has.npmignore, I thought writing and then deleting the files would be an acceptable approach (not to mention easier to review), but actually adding the.npmignorefiles to Git would be trivial if necessary.