fix(template-base): use minimum instead of exact version when replacing ELECTRON_FORGE/VERSION in templates#3030
Merged
MarshallOfSound merged 1 commit intoelectron:mainfrom Oct 31, 2022
Conversation
…ng `ELECTRON_FORGE/VERSION` in templates
ELECTRON_FORGE/VERSION in templates
3 tasks
georgexu99
approved these changes
Oct 31, 2022
MarshallOfSound
approved these changes
Oct 31, 2022
Member
MarshallOfSound
left a comment
There was a problem hiding this comment.
This aligns with siblingDep in init-npm 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This PR ensures that the most recent compatible version of
@electron-forge/plugin-webpackwill be installed bycreate-electron-app. While thepackage.jsonmight still show an older version when usingcreate-electron-app(as outlined in #3019 (comment)), the versionyarn/npmwill actually install is the most recent.