Skip to content

Comments

fix(plugin-vite): add vite as a peer dep#3591

Closed
pd4d10 wants to merge 3 commits intoelectron:mainfrom
pd4d10:patch-1
Closed

fix(plugin-vite): add vite as a peer dep#3591
pd4d10 wants to merge 3 commits intoelectron:mainfrom
pd4d10:patch-1

Conversation

@pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 3, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Added vite as a peer dependency.

@pd4d10 pd4d10 requested a review from a team as a code owner May 3, 2024 08:13
pd4d10 added a commit to pd4d10/debugtron that referenced this pull request May 3, 2024
@erickzhao
Copy link
Member

I think we should include Vite as a direct dependency as part of the larger refactor effort in #3583.

@erickzhao erickzhao closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants