feat: add preStart hook and port existing startLogic impls#3720
Merged
georgexu99 merged 2 commits intomainfrom Nov 12, 2024
Merged
feat: add preStart hook and port existing startLogic impls#3720georgexu99 merged 2 commits intomainfrom
georgexu99 merged 2 commits intomainfrom
Conversation
erickzhao
previously requested changes
Sep 25, 2024
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
Can we formally deprecate startLogic instead of removing it in this PR in case third-party plugin authors are using it right?
MarshallOfSound
force-pushed
the
pre-start
branch
from
28c89e2 to
0e77945
Compare
erickzhao
approved these changes
Sep 26, 2024
Member
erickzhao
left a comment
erickzhao
left a comment
There was a problem hiding this comment.
can't forget to add docs before releasing but LGTM
VerteDinde
approved these changes
Nov 12, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had
postStartso this is pretty chill 🤷 Removes the "only one thing can mess with start logic" restriction for our own plugins.