build(plugin-vite): allow renderer name to contain dashes#3794
Merged
erickzhao merged 2 commits intoelectron:mainfrom Jan 2, 2025
Merged
build(plugin-vite): allow renderer name to contain dashes#3794erickzhao merged 2 commits intoelectron:mainfrom
erickzhao merged 2 commits intoelectron:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Small edit to vite plugin to allow VitePluginRendererConfig entries to have hyphens in their name.
Motivation is we have a large forge repo with multiple applications / frontends. We have them organized as follows:
.
└── src/
├── app-1-frontend-1
├── app-2-frontend-1
├── app-2-frontend-2
└── app-3-frontend-1
In forge v7.4.0, vite.base.config.ts was a part of the vite-typescript template. Ran into the issue while trying to update our dependencies as a result of #3583. This shouldn't break any existing users as if they already had "-" in their name, the build would've already been failing