This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: enable ltcg on windows #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
refack
reviewed
Jun 10, 2019
Contributor
refack
left a comment
refack
left a comment
There was a problem hiding this comment.
FWIW, I think the gist is correct.
tools/generate_config_gypi.py
Outdated
| config['variables']['node_with_ltcg'] = 'true' | ||
| with open(out, 'w') as f: | ||
| f.write("{'variables':{'built_with_electron': 1}}\n") | ||
| f.write(repr(config) + "\n") |
Contributor
There was a problem hiding this comment.
Personally I wouldn't use repr, but rather json.dumps...
Contributor
There was a problem hiding this comment.
Right you are...
Lines 1602 to 1603 in 229bd32
...
node/tools/gyp/pylib/gyp/input.py
Lines 240 to 243 in 229bd32
But still... IMHO repr is less optimal then other options, and json is the most normative format that's compatible with GYP[3] ¯\(ツ)/¯
Contributor
Author
There was a problem hiding this comment.
oh, i didn't realise that gyp could read json! cool, will update.
6 tasks
miniak
approved these changes
Jun 10, 2019
zcbenz
approved these changes
Jun 10, 2019
Contributor
Author
|
Apparently this doesn't actually fix the issue according to @miniak |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref electron/electron#18670