Skip to content

chore: remove <Layout> props#389

Closed
erickzhao wants to merge 1 commit intomainfrom
remove-dead-layout-props
Closed

chore: remove <Layout> props#389
erickzhao wants to merge 1 commit intomainfrom
remove-dead-layout-props

Conversation

@erickzhao
Copy link
Member

These show up as undefined props in our .tsx files nowadays.

I think these were removed upstream in facebook/docusaurus#6925

@erickzhao erickzhao requested a review from a team as a code owner March 17, 2023 01:27
@MarshallOfSound MarshallOfSound temporarily deployed to electronjsorg-new-pr-389 March 17, 2023 02:45 Inactive
@dsanders11
Copy link
Member

How do those pages get their HTML <title> elements if not from those props?

It also looks like those props are still documented in the Docusaurus docs: https://docusaurus.io/docs/creating-pages#add-a-react-page

@erickzhao
Copy link
Member Author

Weirdly, it doesn't. I guess these are needed after all. Let me investigate further about why I'm getting intellisense issues, then.

@erickzhao erickzhao closed this Mar 17, 2023
@dsanders11 dsanders11 deleted the remove-dead-layout-props branch March 27, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants