Set toggle input to role="switch" #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested review from
dbkr and
robintown
and removed request for
a team
Deploying compound-web with
|
| Latest commit: |
e0cdb9a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c47d8fa.compound-web.pages.dev |
| Branch Preview URL: | https://hs-toggle-input-should-have.compound-web.pages.dev |
dbkr
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/switch_role, this represents an "on"/"off" state while the default role
checkboxis more generic. I think it's sensible to assume all toggles are switches, and we can use the checkbox type for true checkboxes.