Skip to content

Feature/bca/improve leave space#3759

Merged
BillCarsonFr merged 5 commits into
developfrom
feature/bca/improve_leave_space
Sep 16, 2021
Merged

Feature/bca/improve leave space#3759
BillCarsonFr merged 5 commits into
developfrom
feature/bca/improve_leave_space

Conversation

@BillCarsonFr
Copy link
Copy Markdown
Member

@BillCarsonFr BillCarsonFr commented Jul 30, 2021

Fixes #3692
M9.1 Spaces | Allow to also leave rooms when leaving a space

When leaving you have 3 choices, leave all rooms of this space , leave none, or select which one to leave.
Also displays a warning message if you won't be able to re-join or if you are the last admin ...

image

@BillCarsonFr BillCarsonFr added the A-Spaces Spaces, groups, communities label Jul 30, 2021
@BillCarsonFr BillCarsonFr added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Aug 24, 2021
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/improve_leave_space branch from ee221c4 to c7e1f39 Compare August 24, 2021 14:55
bmarty
bmarty requested changes Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX is a bit weird when selecting "Leave specific rooms and spaces", but it's working.

On the bottom sheet, it could be better to align horizontally "Leave Space" and "Cancel". But I would remove the "Cancel" anyway, it's a bit useless, and aligne "Leave space" to the right. Also the text color is not correct in dark theme (it's black and should be white. Bg is red which is OK)

On the Pick room Activity, It should be nice to have a option to select / unselect all rooms.

When pressing back from the Activity (I would also remove the cancel here), we should stay on the bottom sheet with the 3rd radio button check and would only be able to leave the space from here (and not from the Activity).

UX is a bit too bad to be mergeable.

Comment thread vector/src/main/java/im/vector/app/features/spaces/SpaceMenuViewAction.kt Outdated
Comment thread vector/src/main/java/im/vector/app/features/spaces/SpaceMenuViewModel.kt
Comment thread vector/src/main/java/im/vector/app/features/spaces/leave/SpaceLeaveAdvancedActivity.kt Outdated
Comment thread vector/src/main/java/im/vector/app/features/spaces/leave/SpaceLeaveAdvancedActivity.kt Outdated
Comment thread vector/src/main/java/im/vector/app/features/spaces/leave/SpaceLeaveAdvancedFragment.kt Outdated
Comment thread vector/src/main/java/im/vector/app/features/spaces/leave/SpaceLeaveAdvancedViewModel.kt Outdated
Comment thread vector/src/main/res/layout/bottom_sheet_leave_space.xml Outdated
Comment thread vector/src/main/res/layout/bottom_sheet_leave_space.xml
Comment thread vector/src/main/res/values/strings.xml Outdated
Comment thread vector/src/main/res/values/strings.xml Outdated
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/improve_leave_space branch from c7e1f39 to 903d4b7 Compare September 1, 2021 09:35
bmarty
bmarty requested changes Sep 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. One remark about translations, sorry :/

Comment thread vector/src/main/res/values-ar/strings.xml
<string name="space_explore_activity_title">استكشِف الغُرف</string>
<string name="space_add_child_title">أضف غُرف</string>
<string name="leave_space">غادر المساحة</string>
<string name="space_leave_prompt_msg">هل أنت متأكد أنك تريد مغادرة المساحة؟</string>
Copy link
Copy Markdown
Member

@bmarty bmarty Sep 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove translations. Instruction has been updated here: https://github.com/vector-im/element-android/blob/main/CONTRIBUTING.md#removing-existing-strings

Copy link
Copy Markdown
Member Author

@BillCarsonFr BillCarsonFr Sep 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@BillCarsonFr BillCarsonFr force-pushed the feature/bca/improve_leave_space branch from 903d4b7 to 128ae88 Compare September 16, 2021 07:20
@BillCarsonFr BillCarsonFr force-pushed the feature/bca/improve_leave_space branch from 128ae88 to cfed0f8 Compare September 16, 2021 07:20
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 16, 2021 •
edited
Loading

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8b980e5. ± Comparison against base commit 8b980e5.

♻️ This comment has been updated with latest results.

@BillCarsonFr BillCarsonFr merged commit 8b980e5 into develop Sep 16, 2021
@BillCarsonFr BillCarsonFr deleted the feature/bca/improve_leave_space branch September 16, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmarty bmarty bmarty requested changes

Assignees

No one assigned

Labels

A-Spaces Spaces, groups, communities Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

M9.1 Spaces | Allow to also leave rooms when leaving a space

2 participants

@BillCarsonFr @bmarty