Make read receipt avatar list more compact#5970
Conversation
ofalvai
changed the title
| if (readReceipts.isNotEmpty()) { | ||
| isVisible = true | ||
| for (index in 0 until MAX_RECEIPT_DISPLAYED) { | ||
| val receiptData = readReceipts.getOrNull(index) |
There was a problem hiding this comment.
I deleted this null check because I verified the call chain and List<ReadReceiptData> can never have null elements.
|
|
||
| <string name="generic_label_and_value">%1$s: %2$s</string> | ||
| <string name="x_plus">%d+</string> | ||
| <string name="x_plus">+%d</string> |
There was a problem hiding this comment.
Is this okay to modify an existing string in such a simple case? I checked all current translations and every instance is the same string as in the default locale, there is no custom translation.
There was a problem hiding this comment.
yes, this is OK. But with the new form, I think it would be better to have some avatars displayed, and after the "+3" text. Will check with design
ouchadam
added
X-Needs-Design
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Can you add a file for the changelog please?
See more info here: https://github.com/vector-im/element-android/blob/main/CONTRIBUTING.md#changelog
Then I think this PR can be merged.
3 participants
Type of change
Content
Make the read receipt avatar list more compact by only displaying 3 avatars and have some negative spacing.
Motivation and context
Similar to how Element Web displays read receipts now: matrix-org/matrix-react-sdk#8389
Screenshots / GIFs
The same read receipt state in Element Web:
Tests
Tested devices
Checklist
Signed-off-by: Olivér Falvai ofalvai@gmail.com