Skip to content

[Device Management] Save matrix_client_information events on login/registration (PSG-769, PSG-771)#7276

Merged
mnaturel merged 16 commits into
developfrom
feature/mna/device-manager-account-data
Oct 12, 2022
Merged

[Device Management] Save matrix_client_information events on login/registration (PSG-769, PSG-771)#7276
mnaturel merged 16 commits into
developfrom
feature/mna/device-manager-account-data

Conversation

@mnaturel
Copy link
Copy Markdown
Contributor

@mnaturel mnaturel commented Oct 3, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding a new step after the Session has been configured and started: update if needed of Matrix client info in AccountData which will be used in Session details screen to render Application section.
A new use case has been introduced ConfigureAndStartSessionUseCase which replaces the extension method Session.configureAndStart().

Motivation and context

Closes #7257

Screenshots / GIFs

N/A

Tests

  • Login to an account
  • Check (using Flipper for example) that the request to update the AccountData is correctly sent when client info has changed (app name or version)

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel changed the title [Device Management] Save matrix_client_information events on login/registration [Device Management] Save matrix_client_information events on login/registration (PSG-769, PSG-771) Oct 3, 2022
@mnaturel mnaturel marked this pull request as ready for review October 3, 2022 15:10
@mnaturel mnaturel requested review from a team and onurays and removed request for a team October 3, 2022 15:11
@mnaturel
Copy link
Copy Markdown
Contributor Author

mnaturel commented Oct 4, 2022

Need to fix the UpdateMatrixClientInfoUseCaseTest but I cannot find the solution to test methods which launches coroutines inside a custom CoroutineScope like I did in the implementation.

@mnaturel mnaturel requested review from a team and ericdecanini and removed request for a team and onurays October 5, 2022 09:06
@mnaturel mnaturel force-pushed the feature/mna/device-manager-account-data branch from 383cef9 to fbb6aa5 Compare October 5, 2022 09:22
@mnaturel
Copy link
Copy Markdown
Contributor Author

mnaturel commented Oct 5, 2022

Need to fix the UpdateMatrixClientInfoUseCaseTest but I cannot find the solution to test methods which launches coroutines inside a custom CoroutineScope like I did in the implementation.

I changed the implementation to ease the testing (see 5647e7b), normally it should be okay now.

@mnaturel mnaturel force-pushed the feature/mna/device-manager-account-data branch from 5647e7b to 71f15d4 Compare October 6, 2022 07:54
@mnaturel mnaturel requested review from a team and fedrunov and removed request for a team and ericdecanini October 10, 2022 08:05
@mnaturel mnaturel force-pushed the feature/mna/device-manager-account-data branch from 71f15d4 to 4aca1dc Compare October 11, 2022 12:44
Copy link
Copy Markdown
Contributor

@fedrunov fedrunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Oct 12, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit 6626732 into develop Oct 12, 2022
@mnaturel mnaturel deleted the feature/mna/device-manager-account-data branch October 12, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Device Management] Save matrix_client_information events on login/registration

2 participants