create encrypted DM for user invite by email#8172
Merged
Merged
Conversation
yostyle
requested review from
a team,
giomfo and
jonnyandrew
and removed request for
a team
yostyle
force-pushed
the
yostyle/create_dm_by_email
branch
from
2e49def to
fb5732f
Compare
3 tasks
jonnyandrew
approved these changes
Feb 28, 2023
giomfo
reviewed
Mar 1, 2023
yostyle
force-pushed
the
yostyle/create_dm_by_email
branch
from
3466501 to
df4824c
Compare
giomfo
reviewed
Mar 3, 2023
Member
|
@yostyle I did some additional tests the changes prevent the end users from inviting email and matrix id at the same time in an existing room |
giomfo
approved these changes
Mar 3, 2023
Member
giomfo
left a comment
giomfo
left a comment
There was a problem hiding this comment.
LGTM, all test ok.
Please wait for all platforms to be ready before merging this PR
yostyle
force-pushed
the
yostyle/create_dm_by_email
branch
from
e4a07c8 to
b217ec5
Compare
yostyle
added
the
Z-NextRelease
Co-authored-by: jonnyandrew <jonny.andrew@protonmail.com>
yostyle
force-pushed
the
yostyle/create_dm_by_email
branch
from
c94228c to
2e71730
Compare
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6912