[Feature] Support delayed event delegation for legacy JWT request#3946
Merged
fkwp merged 3 commits intoMay 5, 2026
Merged
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/livekit/openIDSFU.ts
Did you find this useful? React with a 👍 or 👎 |
BillCarsonFr
approved these changes
May 5, 2026
Member
BillCarsonFr
left a comment
There was a problem hiding this comment.
Looks like this is doing a bit more that delegation? The js-sdk thing about maximumNetworkErrorRetryCount?
Contributor
Author
fair -- however, its very related. |
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If, e.g., the homeserver is restarted due to k8s rescaling the CS API is offline for a short amount of time. If in this period an Element Call client disconnects (closing browser tab, network issues, etc.) the belonging MatrixRTC membership is not cleaned up. This resolves once the delayed event with the leave event is sent. Typically the delayed event timeout is in the order of 30-90 seconds, which is perceived as a long period of time.
This PR
maximumNetworkErrorRetryCountto NOT fail during (the increased) timeouts.Note: The deployed MatrixRTC stack requires a MatrixRTC Authorization Service (lk-jwt-service) to support the delegation feature, which is currently a PR.